Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quiet flag in npm plugin. was always on #1161

Merged
merged 1 commit into from Apr 20, 2020
Merged

fix quiet flag in npm plugin. was always on #1161

merged 1 commit into from Apr 20, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Apr 20, 2020

📦 Published PR as canary version: under canary scope @auto-canary@9.28.3-canary.1161.15033.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.28.3-canary.1161.15033.0
npm install @auto-canary/auto@9.28.3-canary.1161.15033.0
npm install @auto-canary/core@9.28.3-canary.1161.15033.0
npm install @auto-canary/all-contributors@9.28.3-canary.1161.15033.0
npm install @auto-canary/brew@9.28.3-canary.1161.15033.0
npm install @auto-canary/chrome@9.28.3-canary.1161.15033.0
npm install @auto-canary/cocoapods@9.28.3-canary.1161.15033.0
npm install @auto-canary/conventional-commits@9.28.3-canary.1161.15033.0
npm install @auto-canary/crates@9.28.3-canary.1161.15033.0
npm install @auto-canary/exec@9.28.3-canary.1161.15033.0
npm install @auto-canary/first-time-contributor@9.28.3-canary.1161.15033.0
npm install @auto-canary/gh-pages@9.28.3-canary.1161.15033.0
npm install @auto-canary/git-tag@9.28.3-canary.1161.15033.0
npm install @auto-canary/gradle@9.28.3-canary.1161.15033.0
npm install @auto-canary/jira@9.28.3-canary.1161.15033.0
npm install @auto-canary/maven@9.28.3-canary.1161.15033.0
npm install @auto-canary/npm@9.28.3-canary.1161.15033.0
npm install @auto-canary/omit-commits@9.28.3-canary.1161.15033.0
npm install @auto-canary/omit-release-notes@9.28.3-canary.1161.15033.0
npm install @auto-canary/released@9.28.3-canary.1161.15033.0
npm install @auto-canary/s3@9.28.3-canary.1161.15033.0
npm install @auto-canary/slack@9.28.3-canary.1161.15033.0
npm install @auto-canary/twitter@9.28.3-canary.1161.15033.0
npm install @auto-canary/upload-assets@9.28.3-canary.1161.15033.0
# or 
yarn add @auto-canary/bot-list@9.28.3-canary.1161.15033.0
yarn add @auto-canary/auto@9.28.3-canary.1161.15033.0
yarn add @auto-canary/core@9.28.3-canary.1161.15033.0
yarn add @auto-canary/all-contributors@9.28.3-canary.1161.15033.0
yarn add @auto-canary/brew@9.28.3-canary.1161.15033.0
yarn add @auto-canary/chrome@9.28.3-canary.1161.15033.0
yarn add @auto-canary/cocoapods@9.28.3-canary.1161.15033.0
yarn add @auto-canary/conventional-commits@9.28.3-canary.1161.15033.0
yarn add @auto-canary/crates@9.28.3-canary.1161.15033.0
yarn add @auto-canary/exec@9.28.3-canary.1161.15033.0
yarn add @auto-canary/first-time-contributor@9.28.3-canary.1161.15033.0
yarn add @auto-canary/gh-pages@9.28.3-canary.1161.15033.0
yarn add @auto-canary/git-tag@9.28.3-canary.1161.15033.0
yarn add @auto-canary/gradle@9.28.3-canary.1161.15033.0
yarn add @auto-canary/jira@9.28.3-canary.1161.15033.0
yarn add @auto-canary/maven@9.28.3-canary.1161.15033.0
yarn add @auto-canary/npm@9.28.3-canary.1161.15033.0
yarn add @auto-canary/omit-commits@9.28.3-canary.1161.15033.0
yarn add @auto-canary/omit-release-notes@9.28.3-canary.1161.15033.0
yarn add @auto-canary/released@9.28.3-canary.1161.15033.0
yarn add @auto-canary/s3@9.28.3-canary.1161.15033.0
yarn add @auto-canary/slack@9.28.3-canary.1161.15033.0
yarn add @auto-canary/twitter@9.28.3-canary.1161.15033.0
yarn add @auto-canary/upload-assets@9.28.3-canary.1161.15033.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #1161 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1161   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files          54       54           
  Lines        3916     3916           
  Branches      800      842   +42     
=======================================
  Hits         3174     3174           
  Misses        529      529           
  Partials      213      213           
Impacted Files Coverage Δ
plugins/npm/src/index.ts 74.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ec5ede...a4b5c04. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 59dffdb into master Apr 20, 2020
@hipstersmoothie hipstersmoothie deleted the logs branch April 20, 2020 18:13
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.28.3 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants